fix: copy the unsafe row otherwise the queue will have all the same rows #3026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As discussed offline, the java/spark/src/main/java/com/lancedb/lance/spark/write/LanceArrowWriter.java is for zero copy write to Lance. |
|
OK, I will refactor the queue later. But I think it's a fast fix for use. |
|
Close this PR since this ISSUE will be fixed in #3110 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unsafe row use the same referrence of rows.
When we offer rows to queue, all the rows in queu will be same.
Copy the internal row to avoid this issue.