chore: (no changes)

[imotai]

Based on the requirements outlined in issue #3073, I believe moving all proto files to a standalone module would provide a better experience for library users.
By the way. I am one of the users.

[wjones127]

👍 Creating a new package makes sense.

However, I think instead of using a build.rs script, the ticket asks us to check in the generated files. So I think the acceptance criteria here are:

1. No build.rs should need protoc. All the protoc files should be generated manually when the files are changed.
   • As part of this, we should be able to remove all CI job lines that require protoc. For example:

     lance/.github/workflows/rust.yml

     Line 70 in 638eaf4

     sudo apt install -y protobuf-compiler libssl-dev

2. There needs to be a CI job to validate that the generated protobuf definitions are in sync with the .proto files. One possibility is running the protobuf build script and then using git to see if there are any changes.

[imotai]

1. Done
2. I believe we still need build.rs to regenerate the code file whenever the protobuf file changes

[wjones127]

I believe we still need build.rs to regenerate the code file whenever the protobuf file changes

I think as long as there is a build.rs, it will mean there is a build time dependency on protoc.

Here is a good inspiration from another project that demonstrates putting generating the protobuf artifacts in a separate script: apache/arrow-rs#3927

[loloxwg]

Is this pull request still in progress? i am still unable to compile due to issues with protoc. @wjones127

[wjones127]

Weird that this was closed. It has zero commits.

@imotai do you still plan on working on this? If so, feel free to open a fresh PR.