Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix error about schema is not writable pd to pa #3109

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Jay-ju
Copy link

@Jay-ju Jay-ju commented Nov 9, 2024

Fix bug : #3108

@github-actions github-actions bot added the python label Nov 9, 2024
Copy link

github-actions bot commented Nov 9, 2024

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@Jay-ju Jay-ju changed the title [BugFix] fix error about schema is not writable pd to pa fix: fix error about schema is not writable pd to pa Nov 9, 2024
@github-actions github-actions bot added the bug Something isn't working label Nov 9, 2024
…exception will be thrown during type conversion.

Refs: lancedb#3108
Copy link
Contributor

@eddyxu eddyxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice.
Minor ask: could you add a test to cover this code path?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants