Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: allow passing down existing dataset for write #3119

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

wjones127
Copy link
Contributor

@wjones127 wjones127 commented Nov 11, 2024

BREAKING CHANGE: return value in Rust of write_fragments() has changed to Result<Transaction>.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.79365% with 122 lines in your changes missing coverage. Please review.

Project coverage is 77.14%. Comparing base (4ab270b) to head (7dfb807).

Files with missing lines Patch % Lines
rust/lance/src/dataset/write/insert.rs 77.22% 48 Missing and 11 partials ⚠️
rust/lance/src/dataset/write/commit.rs 75.96% 43 Missing and 7 partials ⚠️
rust/lance/src/dataset.rs 76.66% 4 Missing and 3 partials ⚠️
rust/lance/src/dataset/write.rs 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3119      +/-   ##
==========================================
+ Coverage   77.12%   77.14%   +0.02%     
==========================================
  Files         240      242       +2     
  Lines       80652    80924     +272     
  Branches    80652    80924     +272     
==========================================
+ Hits        62203    62429     +226     
- Misses      15279    15325      +46     
  Partials     3170     3170              
Flag Coverage Δ
unittests 77.14% <75.79%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wjones127 wjones127 changed the title perf: allow passing down existing dataset for write feat!: allow passing down existing dataset for write Nov 13, 2024
@github-actions github-actions bot added enhancement New feature or request java labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants