-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: allow passing down existing dataset for write #3119
Draft
wjones127
wants to merge
8
commits into
lancedb:main
Choose a base branch
from
wjones127:perf/pass-down-dataset
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3119 +/- ##
==========================================
+ Coverage 77.12% 77.14% +0.02%
==========================================
Files 240 242 +2
Lines 80652 80924 +272
Branches 80652 80924 +272
==========================================
+ Hits 62203 62429 +226
- Misses 15279 15325 +46
Partials 3170 3170
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wjones127
changed the title
perf: allow passing down existing dataset for write
feat!: allow passing down existing dataset for write
Nov 13, 2024
wjones127
force-pushed
the
perf/pass-down-dataset
branch
from
November 14, 2024 00:31
5bca1f8
to
ea24413
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: return value in Rust of
write_fragments()
has changed toResult<Transaction>
.write_fragments
andDataset::commit()
#3058InsertBuilder
andCommitBuilder
.CommitBuilder
.LanceDataset.insert()
method to modify existing datasets.Table.add
resetsindex_cache_size
lancedb#1655