Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: low recall with cosine/dot on v3 index types #3141

Merged
merged 8 commits into from
Nov 20, 2024

Conversation

BubbleCal
Copy link
Contributor

@BubbleCal BubbleCal commented Nov 19, 2024

This also supports to create v3 IVF_PQ in Rust, then it introduces a breaking change

Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@github-actions github-actions bot added the chore label Nov 19, 2024
@BubbleCal BubbleCal changed the title chore: support to create v3 IVF_PQ fix: low recall with cosine/dot on v3 IVF_PQ Nov 19, 2024
@github-actions github-actions bot added the bug Something isn't working label Nov 19, 2024
@BubbleCal BubbleCal changed the title fix: low recall with cosine/dot on v3 IVF_PQ fix!: low recall with cosine/dot on v3 IVF_PQ Nov 19, 2024
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@github-actions github-actions bot added the java label Nov 19, 2024
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@BubbleCal BubbleCal changed the title fix!: low recall with cosine/dot on v3 IVF_PQ fix!: low recall on v3 index types Nov 19, 2024
@BubbleCal BubbleCal changed the title fix!: low recall on v3 index types fix!: low recall with cosine/dot on v3 index types Nov 19, 2024
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@BubbleCal BubbleCal marked this pull request as ready for review November 19, 2024 12:24
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.

Project coverage is 77.92%. Comparing base (c47543f) to head (6ce5d7d).

Files with missing lines Patch % Lines
rust/lance-index/src/vector/pq.rs 66.66% 3 Missing ⚠️
rust/lance/src/index/vector/builder.rs 0.00% 0 Missing and 2 partials ⚠️
java/core/lance-jni/src/utils.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3141      +/-   ##
==========================================
+ Coverage   77.91%   77.92%   +0.01%     
==========================================
  Files         240      240              
  Lines       81465    81462       -3     
  Branches    81465    81462       -3     
==========================================
+ Hits        63470    63483      +13     
+ Misses      14816    14812       -4     
+ Partials     3179     3167      -12     
Flag Coverage Δ
unittests 77.92% <73.91%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@BubbleCal BubbleCal merged commit 71f323a into lancedb:main Nov 20, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants