feat: make dataset version serializable #3143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjones127
approved these changes
Nov 19, 2024
wjones127
changed the title
wjones127
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3143 +/- ##
=======================================
Coverage 77.92% 77.93%
=======================================
Files 242 242
Lines 81738 81739 +1
Branches 81738 81739 +1
=======================================
+ Hits 63695 63702 +7
- Misses 14861 14864 +3
+ Partials 3182 3173 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
albertlockett
added a commit
to lancedb/lancedb
that referenced
this pull request
Nov 21, 2024
…1850) Will require update to lance dependency to bring in this change which makes the version serializable lancedb/lance#3143
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used when we add list_versions to the remote SDK