Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix dynamodb drop table #3152

Merged
merged 6 commits into from
Nov 22, 2024
Merged

fix: fix dynamodb drop table #3152

merged 6 commits into from
Nov 22, 2024

Conversation

LuQQiu
Copy link
Contributor

@LuQQiu LuQQiu commented Nov 21, 2024

First PR of lancedb/lancedb#1812

Add the delete function to external manifest to delete manifest related metadata during drop_table

Copy link

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@LuQQiu
Copy link
Contributor Author

LuQQiu commented Nov 21, 2024

Second PR: lancedb/lancedb#1866
which wait for lance release

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 63.41463% with 15 lines in your changes missing coverage. Please review.

Project coverage is 77.89%. Comparing base (920b191) to head (fa0e45d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ust/lance-table/src/io/commit/external_manifest.rs 0.00% 8 Missing ⚠️
rust/lance-table/src/io/commit/dynamodb.rs 85.18% 2 Missing and 2 partials ⚠️
rust/lance-table/src/io/commit.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3152      +/-   ##
==========================================
+ Coverage   77.87%   77.89%   +0.01%     
==========================================
  Files         242      242              
  Lines       82214    82368     +154     
  Branches    82214    82368     +154     
==========================================
+ Hits        64028    64157     +129     
- Misses      14987    15004      +17     
- Partials     3199     3207       +8     
Flag Coverage Δ
unittests 77.89% <63.41%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@LuQQiu LuQQiu changed the title Fix dynamodb drop table fix: fix dynamodb drop table Nov 21, 2024
@github-actions github-actions bot added the bug Something isn't working label Nov 21, 2024
@LuQQiu LuQQiu merged commit 1fd513f into lancedb:main Nov 22, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants