-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: improve constructing dist table #3155
perf: improve constructing dist table #3155
Conversation
BubbleCal
commented
Nov 22, 2024
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
dot distance type doesn't benefit much from this optimization, any ideas? @eddyxu |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3155 +/- ##
==========================================
- Coverage 77.95% 77.95% -0.01%
==========================================
Files 242 242
Lines 82436 82511 +75
Branches 82436 82511 +75
==========================================
+ Hits 64262 64318 +56
- Misses 14960 14985 +25
+ Partials 3214 3208 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
do we know if this is memory-bandwidth bound or just compute bound? we can look into that later. |
I think it's still compute bound, because L2 is much faster than dot, I'm thinking whether the 1-dot way leads to the compiler can't generate good enough code |