Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix storage options for ray #3164

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

chenkovsky
Copy link
Contributor

No description provided.

@github-actions github-actions bot added bug Something isn't working python labels Nov 23, 2024
Copy link
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main changes look good. But want the test to be in a different location.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the integration tests together. Could you move the new test to this file: https://github.com/lancedb/lance/blob/main/python/python/tests/test_s3_ddb.py ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved

@wjones127 wjones127 merged commit 6edb1b8 into lancedb:main Dec 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants