Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: improve dot distance computing #3169

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Conversation

BubbleCal
Copy link
Contributor

@BubbleCal BubbleCal commented Nov 25, 2024

for 8bit:
time: [582.61 µs 585.08 µs 587.42 µs]
change: [-9.7495% -6.2223% -2.3288%] (p = 0.01 < 0.10)
Performance has improved.

for 4bit:
time: [549.20 µs 551.13 µs 553.55 µs]
change: [-38.117% -37.734% -37.350%] (p = 0.00 < 0.10)
Performance has improved.

Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@BubbleCal BubbleCal changed the title perf: inline dot distance computing perf: improve dot distance computing Nov 25, 2024
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.04%. Comparing base (9c08d2d) to head (a673bf3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3169      +/-   ##
==========================================
+ Coverage   78.01%   78.04%   +0.02%     
==========================================
  Files         243      243              
  Lines       82890    82889       -1     
  Branches    82890    82889       -1     
==========================================
+ Hits        64670    64690      +20     
- Misses      14999    15003       +4     
+ Partials     3221     3196      -25     
Flag Coverage Δ
unittests 78.04% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@BubbleCal BubbleCal marked this pull request as ready for review November 25, 2024 08:41
Copy link
Contributor

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

@BubbleCal BubbleCal merged commit bfd8ec9 into lancedb:main Nov 25, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants