Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade arrow (to 53) & datafusion (to 42) #3201

Merged
merged 28 commits into from
Dec 4, 2024

Conversation

westonpace
Copy link
Contributor

No description provided.

@github-actions github-actions bot added enhancement New feature or request python labels Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

Copy link
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work. Thank you!

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 70.12987% with 23 lines in your changes missing coverage. Please review.

Project coverage is 78.66%. Comparing base (6edb1b8) to head (2a63d5e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance/src/utils/tfrecord.rs 0.00% 11 Missing ⚠️
rust/lance-core/src/error.rs 0.00% 6 Missing ⚠️
rust/lance-datafusion/src/substrait.rs 89.28% 3 Missing ⚠️
rust/lance-arrow/src/lib.rs 90.47% 2 Missing ⚠️
rust/lance-encoding-datafusion/src/zone.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3201      +/-   ##
==========================================
- Coverage   78.68%   78.66%   -0.02%     
==========================================
  Files         243      243              
  Lines       82853    82889      +36     
  Branches    82853    82889      +36     
==========================================
+ Hits        65190    65204      +14     
- Misses      14879    14901      +22     
  Partials     2784     2784              
Flag Coverage Δ
unittests 78.66% <70.12%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@westonpace westonpace changed the title feat: Upgrade arrow (to 53) & datafusion (to 42) feat: upgrade arrow (to 53) & datafusion (to 42) Dec 4, 2024
@westonpace
Copy link
Contributor Author

@wjones127 it appears the newer version of substrait (required by the newer version of datafusion) now has optional fields which bumps our minimum protobuf-compiler version up to "something more recent than 3.12" where 3.12 is the default on Ubuntu 22.04. I've changed our Java CI to use Ubuntu 24 now but I think this will cause headaches in the future for users. I think we should proceed for now but wanted to give you a heads up.

@westonpace
Copy link
Contributor Author

I'll make a ticket. I think we can maybe work around the issue by adding --experimental_allow_proto3_optional. Also, to be clear, this would only affect Rust users (but will affect lancedb rust users once we update lancedb).

@westonpace westonpace merged commit 955749e into lancedb:main Dec 4, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants