-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade arrow (to 53) & datafusion (to 42) #3201
feat: upgrade arrow (to 53) & datafusion (to 42) #3201
Conversation
…into jleibs/update_arrow_datafusion
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
…f the schema has structs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work. Thank you!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3201 +/- ##
==========================================
- Coverage 78.68% 78.66% -0.02%
==========================================
Files 243 243
Lines 82853 82889 +36
Branches 82853 82889 +36
==========================================
+ Hits 65190 65204 +14
- Misses 14879 14901 +22
Partials 2784 2784
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@wjones127 it appears the newer version of substrait (required by the newer version of datafusion) now has optional fields which bumps our minimum protobuf-compiler version up to "something more recent than 3.12" where 3.12 is the default on Ubuntu 22.04. I've changed our Java CI to use Ubuntu 24 now but I think this will cause headaches in the future for users. I think we should proceed for now but wanted to give you a heads up. |
I'll make a ticket. I think we can maybe work around the issue by adding |
No description provided.