Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: execute_uncommitted for merge insert #3233

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wjones127
Copy link
Contributor

Allows separating write and commit step of merge-insert.

@github-actions github-actions bot added enhancement New feature or request python labels Dec 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 75.75758% with 8 lines in your changes missing coverage. Please review.

Project coverage is 78.48%. Comparing base (7ec23f0) to head (ac5bca8).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance/src/dataset/write/merge_insert.rs 75.75% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3233   +/-   ##
=======================================
  Coverage   78.48%   78.48%           
=======================================
  Files         245      245           
  Lines       84998    85024   +26     
  Branches    84998    85024   +26     
=======================================
+ Hits        66707    66728   +21     
- Misses      15473    15485   +12     
+ Partials     2818     2811    -7     
Flag Coverage Δ
unittests 78.48% <75.75%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wjones127 wjones127 force-pushed the merge-insert-uncommitted branch from 3f1be99 to fd4508d Compare December 20, 2024 20:09
expose in python

refactor: make transaction marshalling easier

cleanup

fix tests

fix path backward compatibility

fix repr

get changes back
@wjones127 wjones127 force-pushed the merge-insert-uncommitted branch from fd4508d to 1173939 Compare December 20, 2024 20:13
@wjones127 wjones127 marked this pull request as ready for review December 20, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants