fix: correctly copy null buffer when making deep copy #3238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some situations an array could be sliced in such a way that the array had no offset, but the array's null buffer did have an offset. In these cases we were not deep copying the array correctly and the offset of the null buffer was lost. This does mean, in some cases, the 2.0 writer could write incorrect nulls. However, the input conditions would mean that the user's data would have to originate from rust in such a way that it was sliced like this. It would be impossible for batches from the C data interface or from python to look like this.