Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make it possible to build lance without protoc (except on Windows) #3363

Merged
merged 8 commits into from
Jan 10, 2025

Conversation

westonpace
Copy link
Contributor

Inspired by substrait-io/substrait-validator#356 this PR adds a protoc feature to lance. If the feature is specified then we will use protobuf-src to build a vendored copy of protoc.

This increases build times slightly (need to compile protoc as part of the build) but removes the need for an external copy of protoc.

At the moment it is not possible to build both the protoc and substrait features because datafusion-substrait does not yet have its own protoc feature (but it will hopefully have one added soon).

@github-actions github-actions bot added the enhancement New feature or request label Jan 9, 2025
@github-actions github-actions bot added the python label Jan 9, 2025
@@ -59,7 +59,7 @@ jobs:
env:
# Need up-to-date compilers for kernels
CC: clang
CXX: clang
CXX: clang++
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@westonpace
Copy link
Contributor Author

I thought the change was pushing us into "too long to build" but it looks like we were already riding that line. Turns out we were building the tests twice I think on stable builds so I disabled the second build.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.44%. Comparing base (397edeb) to head (8a64711).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3363      +/-   ##
==========================================
- Coverage   78.63%   78.44%   -0.20%     
==========================================
  Files         250      250              
  Lines       89836    90067     +231     
  Branches    89836    90067     +231     
==========================================
+ Hits        70646    70650       +4     
- Misses      16281    16496     +215     
- Partials     2909     2921      +12     
Flag Coverage Δ
unittests 78.44% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@westonpace
Copy link
Contributor Author

I want to run CI without the protoc feature (since we are already having issues with long build times). Regrettably there is no way to say "all features except this one" (related: rust-lang/cargo#11467) so the command is a little ugly but it seems to work.

@westonpace westonpace merged commit f478c46 into lancedb:main Jan 10, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants