fix: ensure that 'block_size' parameter is properly propagated in the ObjectStore

[vjc578db]

Previously, setting a block_size parameter did not change the range coalescing being done in FileScheduler's submit_request function. This was because the FileScheduler was using the block_size parameter in the underlying ObjectStore, but that parameter was not being properly propagated in the configure_store method.

This change keeps the same defaults but always uses the parameter value if it is set.

Verified via unit tests and profiling to determine increasing block size now does actually decrease the number of get_range queries.

[github-actions]

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

[wjones127]

Good job catching this issue. I have a minor change needed on the unit test, but otherwise this looks great.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 95.23810% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.73%. Comparing base (7f60aa0) to head (5684cfb).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
rust/lance-io/src/object_store.rs	95.23%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3403      +/-   ##
==========================================
+ Coverage   78.72%   78.73%   +0.01%     
==========================================
  Files         250      250              
  Lines       90879    90915      +36     
  Branches    90879    90915      +36     
==========================================
+ Hits        71540    71580      +40     
+ Misses      16397    16383      -14     
- Partials     2942     2952      +10     

Flag	Coverage Δ
unittests	78.73% <95.23%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[vjc578db]

@wjones127 It looks like it is complaining about not being able to update the lock file (https://github.com/lancedb/lance/actions/runs/12918084538/job/36026972853?pr=3403). Should I be including an updated lock file in this change? I didn't have to do it locally for the tests to pass. If so, should I be running cargo update (which is going to update a lot), or something else?

[wjones127]

@wjones127 It looks like it is complaining about not being able to update the lock file (https://github.com/lancedb/lance/actions/runs/12918084538/job/36026972853?pr=3403). Should I be including an updated lock file in this change? I didn't have to do it locally for the tests to pass. If so, should I be running cargo update (which is going to update a lot), or something else?

This happened because you changed the Cargo.toml file. This should have generated changes in the Cargo.lock files as well, and you should check them in.

You should NOT run cargo update. Just run cargo check in /rust and /python and then check in the updated Cargo.lock files.

[vjc578db]

@wjones127 It looks like it is complaining about not being able to update the lock file (https://github.com/lancedb/lance/actions/runs/12918084538/job/36026972853?pr=3403). Should I be including an updated lock file in this change? I didn't have to do it locally for the tests to pass. If so, should I be running cargo update (which is going to update a lot), or something else?

This happened because you changed the Cargo.toml file. This should have generated changes in the Cargo.lock files as well, and you should check them in.

You should NOT run cargo update. Just run cargo check in /rust and /python and then check in the updated Cargo.lock files.

Added the Cargo.lock file for the lance-io directory. When I ran cargo check in the python/ directory, there were no updates.