Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid divide-by-zero when training an index with a large dimension #3426

Merged
merged 3 commits into from
Jan 31, 2025
Merged

fix: avoid divide-by-zero when training an index with a large dimension #3426

merged 3 commits into from
Jan 31, 2025

Conversation

westonpace
Copy link
Contributor

No description provided.

@westonpace westonpace requested a review from wjones127 January 31, 2025 14:00
@github-actions GitHub Actions
Copy link

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@westonpace westonpace changed the title fix divide-by-zero that could happen when training an index with a large dimension fix: avoid divide-by-zero when training an index with a large dimension Jan 31, 2025
@github-actions github-actions bot added the bug Something isn't working label Jan 31, 2025
@westonpace
Copy link
Contributor Author

Closes #3425

@westonpace westonpace linked an issue Jan 31, 2025 that may be closed by this pull request
v18.1b2 - Rust Future Panicked on building Vector Index with Dot metric #3425
Closed
wjones127
wjones127 approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🤦

@westonpace westonpace merged commit c58814a into lancedb:main Jan 31, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjones127 wjones127 wjones127 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v18.1b2 - Rust Future Panicked on building Vector Index with Dot metric
2 participants
@westonpace @wjones127