Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allocate much memory for residual vectors than needed #3446

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

BubbleCal
Copy link
Contributor

No description provided.

Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@github-actions github-actions bot added the bug Something isn't working label Feb 13, 2025
@BubbleCal BubbleCal marked this pull request as ready for review February 13, 2025 14:33
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.86%. Comparing base (8a61b69) to head (e4e565d).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3446      +/-   ##
==========================================
- Coverage   78.93%   78.86%   -0.08%     
==========================================
  Files         251      251              
  Lines       92267    92821     +554     
  Branches    92267    92821     +554     
==========================================
+ Hits        72833    73202     +369     
- Misses      16463    16642     +179     
- Partials     2971     2977       +6     
Flag Coverage Δ
unittests 78.86% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BubbleCal BubbleCal merged commit a6101e5 into lancedb:main Feb 13, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants