Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lando share complains about format of URL #368

Closed
pirog opened this issue Sep 27, 2017 · 0 comments
Closed

lando share complains about format of URL #368

pirog opened this issue Sep 27, 2017 · 0 comments
Assignees
@pirog
Labels
bug Something aint working right!
Milestone
3.0.0

Comments

@pirog
Copy link
Member

pirog commented Sep 27, 2017

localtunnel requires the subdomain to be formatted in a particular way (eg max length, no hypens, etc). App names that violate this convention cannot use lando share.

We need to make sure lando share translates the appname into a format that makes localtunnel happy.
@pirog pirog added the bug Something aint working right! label Sep 27, 2017
@pirog pirog added this to the 3.0.0-rc.1 milestone Sep 27, 2017
@pirog pirog self-assigned this Sep 27, 2017
pirog added a commit that referenced this issue Oct 1, 2017
@pirog
#312 #368: Improve lando share
59a4374
@pirog pirog closed this as completed Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pirog pirog

Labels
bug Something aint working right!
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@pirog