-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add response_mime_type for gemini models (allow JSON-mode output, optionally) #228
Conversation
Thanks for your contribution!
if you feel like we should also allow to setup its default value during model initialization, I'd suggest to redefine the So that similar things are defined at similar place, and the logic not being spread all over the code base. WDYT? |
Sure thing, I've updated that now. |
@nicsuzor could you finalize it, please? |
@lkuligin Yup, edited accordingly. |
/gcbrun |
/gcbrun |
/gcbrun |
Minor change to optionally add response_mime_type to generation_config. Note this is a preview feature in the Vertex API available for gemini-1.5-pro: https://cloud.google.com/vertex-ai/generative-ai/docs/model-reference/gemini#parameters
Fulfills #144.