Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community: update the default hf bge embeddings #22627

Merged
merged 12 commits into from
Sep 2, 2024
Merged

community: update the default hf bge embeddings #22627

merged 12 commits into from
Sep 2, 2024

Conversation

JonZeolla
Copy link
Contributor

Description: This updates the langchain_community > huggingface > default bge embeddings (the current default recommends this change)
Issue: None
Dependencies: None
Twitter handle: @JonZeolla

@vercel Vercel
Copy link

vercel bot commented Jun 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 2, 2024 10:10pm

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. Ɑ: embeddings Related to text embedding models module 🔌: huggingface Primarily related to HuggingFace integrations 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder 🤖:improvement Medium size change to existing code to handle new use-cases labels Jun 6, 2024
@isahers1
Copy link
Collaborator

Lgtm @baskaryan

@JonZeolla JonZeolla marked this pull request as draft June 12, 2024 18:01
@efriis efriis self-assigned this Jun 12, 2024
@JonZeolla JonZeolla requested a review from baskaryan June 12, 2024 20:54
@JonZeolla JonZeolla marked this pull request as ready for review June 12, 2024 20:54
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jun 12, 2024
@dosubot dosubot bot added the Ɑ: vector store Related to vector store module label Jun 12, 2024
@JonZeolla JonZeolla closed this Jun 12, 2024
@JonZeolla JonZeolla reopened this Jun 12, 2024
@JonZeolla
Copy link
Contributor Author

This hit some kind of issue with all the 3.12 tests added in #22813 taking a long time; retrying...

@ccurme ccurme added the community Related to langchain-community label Jun 18, 2024
@efriis efriis removed their assignment Jul 1, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Sep 2, 2024
@baskaryan baskaryan enabled auto-merge (squash) September 2, 2024 21:42
@baskaryan baskaryan merged commit 78ff51c into langchain-ai:master Sep 2, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baskaryan baskaryan baskaryan approved these changes

Assignees
No one assigned
Labels
community Related to langchain-community 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder Ɑ: embeddings Related to text embedding models module 🔌: huggingface Primarily related to HuggingFace integrations 🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. size:L This PR changes 100-499 lines, ignoring generated files. template Ɑ: vector store Related to vector store module
Projects
PR Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JonZeolla @isahers1 @baskaryan @efriis @ccurme