Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community: Bulk LocalAIEmbeddings #22666

Closed
wants to merge 8 commits into from
Closed

community: Bulk LocalAIEmbeddings #22666

wants to merge 8 commits into from

Conversation

mkhludnev
Copy link
Contributor

Thank you for contributing to LangChain!

Additional guidelines:

@vercel Vercel
Copy link

vercel bot commented Jun 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jun 7, 2024 10:13am

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. Ɑ: embeddings Related to text embedding models module 🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features labels Jun 7, 2024
@isahers1
Copy link
Collaborator

@baskaryan This lgtm - I don't really understand the updates to the YAML file but other than that it makes sense

@mkhludnev
Copy link
Contributor Author

YAMLs are requests and responses recorded by vcr for test stub.

@ccurme ccurme added the community Related to langchain-community label Jun 18, 2024
baskaryan
baskaryan reviewed Sep 2, 2024
View reviewed changes
libs/community/langchain_community/embeddings/localai.py
model: str = "text-embedding-ada-002"
deployment: str = model
openai_api_version: Optional[str] = None
openai_api_base: Optional[str] = None
# to support explicit proxy for LocalAI
openai_proxy: Optional[str] = None
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why delete this?

@mkhludnev mkhludnev mentioned this pull request Sep 20, 2024
Closed
3 tasks
@mkhludnev mkhludnev marked this pull request as draft September 24, 2024 06:13
@mkhludnev mkhludnev mentioned this pull request Sep 24, 2024
Closed
1 task
@efriis
Copy link
Member

efriis commented Dec 11, 2024

has been in draft for a long time. will close, and feel free to reopen if relevant!

This might add a net-new community integration or feature, which has been replaced by dedicated integration packages. If reopened would recommend reopening with just docs updates, as well as registering your package in libs/packages.yml! We'll be able to review simple PRs that only modify these two things much faster :)

Here's the guide, and if you have questions, feel free to leave them in the comments on those pages so others can see them! https://python.langchain.com/docs/contributing/how_to/integrations/

@efriis efriis closed this Dec 11, 2024
@mkhludnev mkhludnev mentioned this pull request Dec 17, 2024
Closed
@mkhludnev
Copy link
Contributor Author

Available in new integration package since https://pypi.org/project/langchain-localai/0.1.2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baskaryan baskaryan baskaryan left review comments

Assignees
No one assigned
Labels
community Related to langchain-community Ɑ: embeddings Related to text embedding models module 🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
PR Reviews
Status: Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mkhludnev @isahers1 @efriis @baskaryan @ccurme