Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConversationalChatAgent: Allow customizing TEMPLATE_TOOL_RESPONSE #2361

Merged
merged 6 commits into from
May 18, 2023
Merged

ConversationalChatAgent: Allow customizing TEMPLATE_TOOL_RESPONSE #2361

merged 6 commits into from
May 18, 2023

Conversation

FOLLGAD
Copy link
Contributor

@FOLLGAD FOLLGAD commented Apr 3, 2023 •
edited
Loading

It's currently not possible to change the TEMPLATE_TOOL_RESPONSE prompt for ConversationalChatAgent, this PR changes that.

hwchase17
hwchase17 reviewed Apr 3, 2023
View reviewed changes
Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it, few minor comments

langchain/agents/conversational_chat/base.py Outdated Show resolved Hide resolved
langchain/agents/conversational_chat/base.py Outdated Show resolved Hide resolved
@FOLLGAD FOLLGAD requested a review from hwchase17 April 4, 2023 15:43
vowelparrot
vowelparrot approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@vowelparrot vowelparrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@MariuszT
Copy link

When do you plan to merge?

@dev2049 dev2049 added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label May 18, 2023
@dev2049 dev2049 merged commit 5c9205d into langchain-ai:master May 18, 2023
@dev2049 dev2049 mentioned this pull request May 19, 2023
Closed
@danielchalef danielchalef mentioned this pull request Jun 5, 2023
Merged
This was referenced Jun 25, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vowelparrot vowelparrot vowelparrot approved these changes

@hwchase17 hwchase17 Awaiting requested review from hwchase17

Assignees
No one assigned
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FOLLGAD @MariuszT @hwchase17 @vowelparrot @dev2049