Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove the extra period in docstring #25414

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

gbaian10
Copy link
Contributor

Remove the period after the hyperlink in the docstring of BaseChatOpenAI.with_structured_output.

I have repeatedly copied the extra period at the end of the hyperlink, which results in a "Page not found" page when pasted into the browser.

Remove the period after the hyperlink in the docstring of BaseChatOpenAI.with_structured_output.
@efriis efriis added the partner label Aug 14, 2024
@efriis efriis self-assigned this Aug 14, 2024
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 14, 2024
Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2024 9:51pm

@dosubot dosubot bot added 🔌: openai Primarily related to OpenAI integrations 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Aug 14, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Aug 14, 2024
@ccurme ccurme merged commit 0a99935 into langchain-ai:master Aug 14, 2024
32 checks passed
olgamurraft pushed a commit to olgamurraft/langchain that referenced this pull request Aug 16, 2024
Remove the period after the hyperlink in the docstring of
BaseChatOpenAI.with_structured_output.

I have repeatedly copied the extra period at the end of the hyperlink,
which results in a "Page not found" page when pasted into the browser.
@gbaian10 gbaian10 deleted the docs/openai_docstring branch August 17, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging. 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs 🔌: openai Primarily related to OpenAI integrations partner size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants