openai[patch]: use max_completion_tokens in place of max_tokens #26917
+75
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:M
|
Integration tests pass: https://github.com/langchain-ai/langchain/actions/runs/11060036967 |
|
How soon should we expect these changes? |
efriis
approved these changes
Oct 3, 2024
dosubot
bot
added
the
lgtm
baskaryan
reviewed
Nov 26, 2024
| @@ -435,7 +435,7 @@ class BaseChatOpenAI(BaseChatModel): | |||
| """Number of chat completions to generate for each prompt.""" | |||
| top_p: Optional[float] = None | |||
| """Total probability mass of tokens to consider at each step.""" | |||
| max_tokens: Optional[int] = None | |||
| max_tokens: Optional[int] = Field(default=None, alias="max_completion_tokens") | |||
There was a problem hiding this comment.
do we need to update azure openai as well? if someone is passing in max_completion_tokens to azure today this change will update so instead max_tokens is passed in
dosubot
bot
added
size:L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
max_tokensis deprecated: https://platform.openai.com/docs/api-reference/chat/create#chat-create-max_tokens