Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typo in llibs/community/langchain_community/storage/sql.py #27029

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Fixed typo in llibs/community/langchain_community/storage/sql.py #27029

merged 3 commits into from
Oct 8, 2024

Conversation

ajayeswarreddy
Copy link
Contributor

@ajayeswarreddy ajayeswarreddy commented Oct 1, 2024 •
edited
Loading

  • PR title: docs: fix typo in SQLStore import path

  • PR message:

    • Description: This PR corrects a typo in the docstrings for the class SQLStore(BaseStore[str, bytes]). The import path in the docstring currently reads from langchain_rag.storage import SQLStore, which should be changed to langchain_community.storage import SQLStore. This typo is also reflected in the official documentation.
    • Issue: N/A
    • Dependencies: None
    • Twitter handle: N/A

@ajayeswarreddy
Fixed typo in llibs/community/langchain_community/storage/sql.py
3fc4b07 
There is a typo in the docstrings for the class SQLStore(BaseStore[str, bytes]). 

This typo is also reflected in the official documentation here https://statics.teams.cdn.office.net/evergreen-assets/safelinks/1/atp-safelinks.html

from lanchain_rag.storage import SQLStore 
needs to be changed to
from langchain_community.storage import SQLStore
@vercel Vercel
Copy link

vercel bot commented Oct 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 5:51pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. community Related to langchain-community 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Oct 1, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Oct 8, 2024
@efriis efriis enabled auto-merge (squash) October 8, 2024 17:42
@efriis efriis self-assigned this Oct 8, 2024
@efriis efriis merged commit 9b7bdf1 into langchain-ai:master Oct 8, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efriis efriis efriis approved these changes

Assignees

@efriis efriis

Labels
community Related to langchain-community 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
PR Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajayeswarreddy @efriis