Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core[patch]: support numpy 2 #27991

Merged
merged 9 commits into from
Nov 14, 2024
Merged

core[patch]: support numpy 2 #27991

merged 9 commits into from
Nov 14, 2024

Conversation

ccurme
Copy link
Collaborator

@ccurme ccurme commented Nov 8, 2024

No description provided.

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 4:50pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Nov 8, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Nov 9, 2024
@pablosjv pablosjv mentioned this pull request Nov 12, 2024
5 tasks
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Nov 13, 2024
@ccurme ccurme merged commit f122273 into master Nov 14, 2024
78 checks passed
@ccurme ccurme deleted the cc/numpy2 branch November 14, 2024 18:08
@ghinch
Copy link
Contributor

ghinch commented Nov 18, 2024

Hi, I can see this patch updated the numpy requirement for langchain-core to now be inclusive of the Numpy 2.x.x versions, but the langchain and langchain-community modules were left at <2. Do new issues/PRs need to be set to update those to match?

rorra added a commit to rorra/langchain that referenced this pull request Nov 24, 2024
…toml`

- Resolves compatibility issues with numpy2.
- Updates `libs/langchain/pyproject.toml` to include the correct requirements for numpy2.

References: [langchain-ai#27991](langchain-ai#27991)
rorra added a commit to rorra/langchain that referenced this pull request Nov 24, 2024
…toml`

- Resolves compatibility issues with numpy2.
- Updates `libs/langchain/pyproject.toml` to include the correct requirements for numpy2.

References: [langchain-ai#27991](langchain-ai#27991)
ccurme added a commit that referenced this pull request Nov 26, 2024
Follows on from #27991, updates the langchain package to support numpy 2
versions

---------

Co-authored-by: Chester Curme <chester.curme@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging. 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs size:S This PR changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants