Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openai: release 0.2.9, o1 streaming #28197

Merged
merged 1 commit into from
Nov 18, 2024
+73 −76
Merged

openai: release 0.2.9, o1 streaming #28197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions libs/partners/openai/langchain_openai/chat_models/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -993,9 +993,6 @@ def _should_stream(
# TODO: Add support for streaming with Pydantic response_format.
warnings.warn("Streaming with Pydantic response_format not yet supported.")
return False
if self.model_name is not None and self.model_name.startswith("o1"):
# TODO: Add support for streaming with o1 once supported.
return False

return super()._should_stream(
async_api=async_api, run_manager=run_manager, **kwargs
Expand Down
Loading
Loading