Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: list valid values for LanceDB constructor's mode argument #28296

Merged

Conversation

metadaddy
Copy link
Contributor

Description:

Currently, the docstring for LanceDB.__init__() provides the default value for mode, but not the list of valid values. This PR adds that list to the docstring.

Issue:

N/A

Dependencies:

N/A

Twitter handle:

@metadaddy

[Leaving as a reminder: If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.]

Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 8:34pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. community Related to langchain-community 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Nov 22, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Nov 22, 2024
@ccurme ccurme merged commit 2ee37a1 into langchain-ai:master Nov 22, 2024
18 checks passed
@metadaddy
Copy link
Contributor Author

Six minutes from submission to merge. Kudos, @ccurme!

@metadaddy metadaddy deleted the add-allowed-values-for-lancedb-mode branch November 22, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants