Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Dria Index completely #28687

Closed
wants to merge 2 commits into from

Conversation

anilaltuner
Copy link
Contributor

Remove Dria from public package LangChain

Description: This PR removes the Dria integration from the public package LangChain. The change eliminates all associated files, references, and dependencies related to Dria to streamline the package and ensure consistency with current project requirements.

Tests and Docs
No new tests are required as this PR pertains to the removal of an existing component.
Updated the documentation to reflect the absence of Dria in the package. Removed any examples or references to Dria in the docs/docs/integrations directory.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 12, 2024
Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 10:07am

@dosubot dosubot bot added community Related to langchain-community 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Dec 12, 2024
@efriis
Copy link
Contributor

efriis commented Dec 12, 2024

hey there! removals like this are a breaking change, so if the service is discontinued for whatever reason, we can add something that helps it fail gracefully, but outright removal like this isn't an option (e.g. this would break anyone's code that imports the component, even if they don't use it).

could you link some documentation from dria showing why this would need to be deleted?

@efriis efriis self-assigned this Dec 12, 2024
@anilaltuner
Copy link
Contributor Author

Hey Erik!

I did not noticed documentation about that and try removing myself.

Dria's retriever component changed to completely different functionality and the library's components are removed. So, all Dria retriever functionality must removed on Langchain Integrations.

Thanks for your help!

@efriis
Copy link
Contributor

efriis commented Dec 13, 2024

got it - do/did you work on dria? could you link me to some documentation related to this? all of their docs still seem to be up, so I'm going to close this and happy to reopen if

  1. it's shown that dria is no longer in service
  2. the PR is updated to keep all files and instead remove the Dria implementation to raise an error on init
  3. CI is passing

easiest one to get out of the way is [1]!

@efriis efriis closed this Dec 13, 2024
@anilaltuner
Copy link
Contributor Author

We'll remove docs from our website, this one is deprecated.

The problem is here;

https://python.langchain.com/docs/integrations/retrievers/dria_index/

It's a misdirection for people using Langchain or Dria. For Langchain, the 2nd item seems more accurate. It is most useful to apply 1-2

@anilaltuner
Copy link
Contributor Author

Hey @efriis! Any update on this?

https://python.langchain.com/docs/integrations/retrievers/dria_index/

Dria docs still available on langchain docs

@efriis
Copy link
Contributor

efriis commented Dec 20, 2024

let me know when you remove the docs, or add a warning to that docs page saying these features are deprecated. a bunch of the pages at https://dria.co/docs/ reference the langchain integration and show how to use it

As mentioned before, steps would be:

  1. it's shown that dria is no longer in service (e.g. by adding a big banner to the langchain/dria docs at dria.co saying retrieval is no longer in service)
  2. the PR is updated to keep all the code and instead remove the Dria implementation to raise an error on init
  3. CI is passing

@anilaltuner
Copy link
Contributor Author

Hey @efriis, we removed old version of https://dria.co/docs/ and new version has nothing to do about langchain integration and old version. Can we now remove Dria's langchain documentation page? It misleads Dria's users and usage

@anilaltuner
Copy link
Contributor Author

Hey @efriis, any update on that? Is there an any thing I can help you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants