-
Notifications
You must be signed in to change notification settings - Fork 16.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing Dria Index completely #28687
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hey there! removals like this are a breaking change, so if the service is discontinued for whatever reason, we can add something that helps it fail gracefully, but outright removal like this isn't an option (e.g. this would break anyone's code that imports the component, even if they don't use it). could you link some documentation from dria showing why this would need to be deleted? |
Hey Erik! I did not noticed documentation about that and try removing myself. Dria's retriever component changed to completely different functionality and the library's components are removed. So, all Dria retriever functionality must removed on Langchain Integrations. Thanks for your help! |
got it - do/did you work on dria? could you link me to some documentation related to this? all of their docs still seem to be up, so I'm going to close this and happy to reopen if
easiest one to get out of the way is [1]! |
We'll remove docs from our website, this one is deprecated. The problem is here; https://python.langchain.com/docs/integrations/retrievers/dria_index/ It's a misdirection for people using Langchain or Dria. For Langchain, the 2nd item seems more accurate. It is most useful to apply 1-2 |
Hey @efriis! Any update on this? https://python.langchain.com/docs/integrations/retrievers/dria_index/ Dria docs still available on langchain docs |
let me know when you remove the docs, or add a warning to that docs page saying these features are deprecated. a bunch of the pages at https://dria.co/docs/ reference the langchain integration and show how to use it As mentioned before, steps would be:
|
Hey @efriis, we removed old version of https://dria.co/docs/ and new version has nothing to do about langchain integration and old version. Can we now remove Dria's langchain documentation page? It misleads Dria's users and usage |
Hey @efriis, any update on that? Is there an any thing I can help you? |
Remove Dria from public package LangChain
Description: This PR removes the Dria integration from the public package LangChain. The change eliminates all associated files, references, and dependencies related to Dria to streamline the package and ensure consistency with current project requirements.
Tests and Docs
No new tests are required as this PR pertains to the removal of an existing component.
Updated the documentation to reflect the absence of Dria in the package. Removed any examples or references to Dria in the docs/docs/integrations directory.