Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added bind_tools support for ChatMLX along with small fix in _stream #28743

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Added bind_tools support for ChatMLX along with small fix in _stream #28743

merged 2 commits into from
Dec 16, 2024

Conversation

keenborder786
Copy link
Contributor

  • Description: Added Support for bind_tool as requested in the issue. Plus two issue in _stream were fixed:
    • Corrected the Positional Argument Passing for generate_step
    • Accountability if token returned by generate_step is integer.
  • Issue: You forgot about ChatMLX.bind_tools #28692

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 16, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Dec 16, 2024 0:12am

@dosubot dosubot bot added community Related to langchain-community 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Dec 16, 2024
@ccurme ccurme merged commit 8d74608 into langchain-ai:master Dec 16, 2024
19 checks passed
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Dec 16, 2024
@ccurme ccurme mentioned this pull request Dec 16, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccurme ccurme ccurme approved these changes

Assignees
No one assigned
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature community Related to langchain-community lgtm PR looks good. Use to confirm that a PR is ready for merging. size:M This PR changes 30-99 lines, ignoring generated files.
Projects
PR Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keenborder786 @ccurme