(Community): Added API Key for Jina Search API Wrapper #29622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:S
efriis
reviewed
Feb 6, 2025
| from yarl import URL | ||
|
|
||
|
|
||
| class JinaSearchAPIWrapper(BaseModel): | ||
| """Wrapper around the Jina search engine.""" | ||
|
|
||
| jina_api_key: SecretStr |
There was a problem hiding this comment.
I do think it's fine.
Although Bing has a bit of different variable name
khelli07
suggested changes
Feb 6, 2025
| @@ -59,6 +75,7 @@ def download_documents(self, query: str) -> List[Document]: | |||
| def _search_request(self, query: str) -> List[dict]: | |||
| headers = { | |||
| "Accept": "application/json", | |||
| "Authorization": self.jina_api_key.get_secret_value(), | |||
There was a problem hiding this comment.
I think this needs to be like this
"Authorization": f"Bearer {self.jina_api_key.get_secret_value()}",
Like in other files as well. Maybe Tavily just have different format of payload.
|
@efriis fixed |
efriis
reviewed
Feb 7, 2025
| @@ -30,7 +30,7 @@ class JinaSearch(BaseTool): # type: ignore[override] | |||
| "each in clean, LLM-friendly text. This way, you can always keep your LLM " | |||
| "up-to-date, improve its factuality, and reduce hallucinations." | |||
| ) | |||
| search_wrapper: JinaSearchAPIWrapper = Field(default_factory=JinaSearchAPIWrapper) | |||
| search_wrapper: JinaSearchAPIWrapper = Field(default_factory=JinaSearchAPIWrapper) # type: ignore[arg-type] | |||
There was a problem hiding this comment.
why was adding this necessary?
There was a problem hiding this comment.
Argument "default_factory" to "Field" has incompatible type "type[JinaSearchAPIWrapper]"; expected "Union[Callable[[], Never], I kept getting above error and also noticed:
TavilySearchResults is also excluding this from the linter:
api_wrapper: TavilySearchAPIWrapper = Field(default_factory=TavilySearchAPIWrapper) # type: ignore[arg-type]
dosubot
bot
added
size:M
Done |
ccurme
approved these changes
Feb 13, 2025
dosubot
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authorizationheader #29596