community: Fix HTTP protocol handling in AzureAISearchRetriever._build_search_url #30886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:M
bug
Author
ccurme
reviewed
Apr 29, 2025
Collaborator
ccurme
left a comment
ccurme
left a comment
There was a problem hiding this comment.
Hello, thanks for this. We've moved langchain-community into a standalone repo. Would you mind opening your PR there?
https://github.com/langchain-ai/langchain-community
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR fixes the URL construction logic in AzureAISearchRetriever to properly handle HTTP protocols when specified in the service name. Previously, when service_name was provided with an HTTP protocol (e.g., "http://my-search-service"), the logic didn't properly handle this case. This is important for users working in service mesh environments like Istio, where internal service-to-service communication often uses HTTP while the mesh handles TLS termination.
Issue: N/A
Dependencies: None