huggingface[major]: Reduce disk footprint by 95% by making large dependencies optional #31268
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:S
|
@ccurme Is this change something you might consider? |
|
Tagging for visibility: @baskaryan, @eyurtsev, @ccurme, @vbarda, @hwchase17 I think this could be a major improvement for anyone who is using |
|
Yes. I think this makes sense. We usually wrap optional dependencies with a try except and re-raise with explicit instructions to the end user (e.g., If you're able to make this change, we can release the integration. We'll release with a properly updated version to mark that this is a breaking change |
eyurtsev
changed the title
|
I believe those guards are already in place everywhere they are needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
langchain_huggingfacehas a very large installation size of around 600 MB (on a Mac with Python 3.11). This is due to its dependency onsentence-transformers, which in turn depends ontorch, which is 320 MB all by itself. Similarly, the depedency ontransformersadds another set of heavy dependencies. With those dependencies removed, the installation oflangchain_huggingfaceonly takes up ~26 MB. This is only 5 % of the full installation!These libraries are not necessary to use
langchain_huggingface's API wrapper classes, only for local inferences/embeddings. All import statements for those two libraries already have import guards in place (try/catch with a helpful "please install x" message).This PR therefore moves those two libraries to an optional dependency group
full. So apip install langchain_huggingfacewill only install the lightweight version, and apip install "langchain_huggingface[full]"will install all dependencies.I know this may break existing code, because
sentence-transformersandtransformersare now no longer installed by default. Given that users will see helpful error messages when that happens, and the major impact of this small change, I hope that you will still consider this PR.Dependencies: No new dependencies, but new optional grouping.