Skip to content

fix: remove unused type ignore from three_values fixture in TestAsyncInMemoryStore #31895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025

Conversation

mdrxy
Copy link
Collaborator

@mdrxy mdrxy commented Jul 7, 2025

No description provided.

@mdrxy mdrxy requested a review from eyurtsev as a code owner July 7, 2025 17:17
Copy link

vercel bot commented Jul 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jul 7, 2025 5:17pm

@mdrxy mdrxy enabled auto-merge (squash) July 7, 2025 17:17
Copy link

codspeed-hq bot commented Jul 7, 2025

CodSpeed WallTime Performance Report

Merging #31895 will improve performances by 10.72%

Comparing mdrxy/remove-unused-type_ignore (ab81edf) with master (8ef01f8)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

⚡ 1 improvements
✅ 12 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_import_time[BaseChatModel] 548 ms 494.9 ms +10.72%

@mdrxy mdrxy disabled auto-merge July 7, 2025 17:21
@mdrxy mdrxy merged commit a751a23 into master Jul 7, 2025
65 of 67 checks passed
@mdrxy mdrxy deleted the mdrxy/remove-unused-type_ignore branch July 7, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant