Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nit] Simplify Spark Creation Validation Check A Little Bit #4761

Merged
merged 1 commit into from
May 19, 2023
Merged

[nit] Simplify Spark Creation Validation Check A Little Bit #4761

merged 1 commit into from
May 19, 2023

Conversation

skcoirz
Copy link
Contributor

@skcoirz skcoirz commented May 16, 2023

  • simplify the validation check a little bit.
  • re-tested in jupyter notebook.

Reviewer: @hwchase17

@skcoirz skcoirz marked this pull request as ready for review May 16, 2023 03:49
hwchase17
hwchase17 approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@hwchase17 hwchase17 merged commit db6f7ed into langchain-ai:master May 19, 2023
@danielchalef danielchalef mentioned this pull request Jun 5, 2023
Merged
This was referenced Jun 25, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchase17 hwchase17 hwchase17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skcoirz @hwchase17