Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add self query translator for weaviate vectorstore #4804

Merged
merged 6 commits into from
May 19, 2023

Conversation

domchan
Copy link
Contributor

@domchan domchan commented May 16, 2023

Add self query translator for weaviate vectorstore

Adds support for the EQ comparator and the AND/OR operators.

@dev2049

@dev2049
Copy link
Contributor

dev2049 commented May 16, 2023

amazing! if you have time it'd be great to add an example notebook (like the ones for chroma and pinecone). if not i can take a stab later today

@dev2049 dev2049 added the needs documentation PR needs to be updated with documentation label May 16, 2023
@domchan
Copy link
Contributor Author

domchan commented May 17, 2023

amazing! if you have time it'd be great to add an example notebook (like the ones for chroma and pinecone). if not i can take a stab later today

no problem I'll put together an example based on the same content as the others

@domchan
Copy link
Contributor Author

domchan commented May 18, 2023

amazing! if you have time it'd be great to add an example notebook (like the ones for chroma and pinecone). if not i can take a stab later today

Done. Largely copied from the Chroma example but has been tested with weaviate.

Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

largely lgtm!

@@ -0,0 +1,60 @@
"""Logic for converting internal query language to a valid Chroma query."""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: docstring

@hwchase17 hwchase17 added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label May 19, 2023
@dev2049 dev2049 merged commit 6c60251 into langchain-ai:master May 19, 2023
@danielchalef danielchalef mentioned this pull request Jun 5, 2023
This was referenced Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging. needs documentation PR needs to be updated with documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants