Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bold Crumbs #4876

Merged
merged 1 commit into from
May 17, 2023
Merged

Bold Crumbs #4876

merged 1 commit into from
May 17, 2023

Conversation

vowelparrot
Copy link
Contributor

No description provided.

@vowelparrot vowelparrot requested a review from agola11 May 17, 2023 19:03
@eyurtsev
Copy link
Collaborator

to go where no one has gone before!

@@ -27,6 +27,11 @@ def get_colored_text(text: str, color: str) -> str:
return f"\u001b[{color_str}m\033[1;3m{text}\u001b[0m"


def get_bolded_text(text: str) -> str:
"""Get bolded text."""
return f"\033[1m{text}\033[0m"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to check if the current shell supports this? I don't know much about these codes....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with the colored text! It's used in a lot of places in LC but will certainly look bad on an ascii terminal

@vowelparrot vowelparrot merged commit 1ff7c95 into master May 17, 2023
@vowelparrot vowelparrot deleted the vwp/bold_headers_stdout branch May 17, 2023 22:50
@danielchalef danielchalef mentioned this pull request Jun 5, 2023
This was referenced Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants