Fixed multi input prompt for MapReduceChain #4979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyurtsev
reviewed
May 19, 2023
imeckr
changed the title
kwargs support for intermediate chains of MapReduceChain via from_params method
|
@dev2049 @hwchase17 @agola11 Can anyone of you review this ? |
|
could we add either an example to the map reduce notebook or an integration test where this is used |
|
@dev2049 Let me know if this example works. |
hwchase17
approved these changes
Jun 3, 2023
Undertone0809
pushed a commit
to Undertone0809/langchain
that referenced
this pull request
Jun 19, 2023
# Fixed multi input prompt for MapReduceChain Added `kwargs` support for inner chains of `MapReduceChain` via `from_params` method Currently the `from_method` method of intialising `MapReduceChain` chain doesn't work if prompt has multiple inputs. It happens because it uses `StuffDocumentsChain` and `MapReduceDocumentsChain` underneath, both of them require specifying `document_variable_name` if `prompt` of their `llm_chain` has more than one `input`. With this PR, I have added support for passing their respective `kwargs` via the `from_params` method. ## Fixes langchain-ai#4752 ## Who can review? @dev2049 @hwchase17 @agola11 --------- Co-authored-by: imeckr <chandanroutray2012@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed multi input prompt for MapReduceChain
Added
kwargssupport for inner chains ofMapReduceChainviafrom_paramsmethodCurrently the
from_methodmethod of intialisingMapReduceChainchain doesn't work if prompt has multiple inputs. It happens because it usesStuffDocumentsChainandMapReduceDocumentsChainunderneath, both of them require specifyingdocument_variable_nameifpromptof theirllm_chainhas more than oneinput.With this PR, I have added support for passing their respective
kwargsvia thefrom_paramsmethod.Fixes #4752
Who can review?
@dev2049 @hwchase17 @agola11