Fix update_document function, add test and documentation. #5359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
|
@atroyn @jeffchuber does this look okay? |
|
@hwchase17 im working on a larger cleanup / refactor of the chroma integration. We can land this and I will probably make a few tweaks in my PR. As far as I know |
|
Hi @jeffchuber, I'm glad to hear that you're undertaking a larger cleanup and refactoring of the Chroma integration. That sounds like a fantastic initiative! I look forward to seeing the improvements and tweaks you'll be making. Yes, it was indeed puzzling to discover that I appreciate your feedback and support on this. Let me know if there's anything specific you'd like me to be aware of or contribute to in your ongoing refactoring efforts. Thanks |
hwchase17
approved these changes
May 29, 2023
vowelparrot
pushed a commit
that referenced
this pull request
May 31, 2023
# Fix for `update_document` Function in Chroma ## Summary This pull request addresses an issue with the `update_document` function in the Chroma class, as described in [#5031](#5031 (comment)). The issue was identified as an `AttributeError` raised when calling `update_document` due to a missing corresponding method in the `Collection` object. This fix refactors the `update_document` method in `Chroma` to correctly interact with the `Collection` object. ## Changes 1. Fixed the `update_document` method in the `Chroma` class to correctly call methods on the `Collection` object. 2. Added the corresponding test `test_chroma_update_document` in `tests/integration_tests/vectorstores/test_chroma.py` to reflect the updated method call. 3. Added an example and explanation of how to use the `update_document` function in the Jupyter notebook tutorial for Chroma. ## Test Plan All existing tests pass after this change. In addition, the `test_chroma_update_document` test case now correctly checks the functionality of `update_document`, ensuring that the function works as expected and updates the content of documents correctly. ## Reviewers @dev2049 This fix will ensure that users are able to use the `update_document` function as expected, without encountering the previous `AttributeError`. This will enhance the usability and reliability of the Chroma class for all users. Thank you for considering this pull request. I look forward to your feedback and suggestions.
Merged
Undertone0809
pushed a commit
to Undertone0809/langchain
that referenced
this pull request
Jun 19, 2023
…ai#5359) # Fix for `update_document` Function in Chroma ## Summary This pull request addresses an issue with the `update_document` function in the Chroma class, as described in [langchain-ai#5031](langchain-ai#5031 (comment)). The issue was identified as an `AttributeError` raised when calling `update_document` due to a missing corresponding method in the `Collection` object. This fix refactors the `update_document` method in `Chroma` to correctly interact with the `Collection` object. ## Changes 1. Fixed the `update_document` method in the `Chroma` class to correctly call methods on the `Collection` object. 2. Added the corresponding test `test_chroma_update_document` in `tests/integration_tests/vectorstores/test_chroma.py` to reflect the updated method call. 3. Added an example and explanation of how to use the `update_document` function in the Jupyter notebook tutorial for Chroma. ## Test Plan All existing tests pass after this change. In addition, the `test_chroma_update_document` test case now correctly checks the functionality of `update_document`, ensuring that the function works as expected and updates the content of documents correctly. ## Reviewers @dev2049 This fix will ensure that users are able to use the `update_document` function as expected, without encountering the previous `AttributeError`. This will enhance the usability and reliability of the Chroma class for all users. Thank you for considering this pull request. I look forward to your feedback and suggestions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for
update_documentFunction in ChromaSummary
This pull request addresses an issue with the
update_documentfunction in the Chroma class, as described in #5031. The issue was identified as anAttributeErrorraised when callingupdate_documentdue to a missing corresponding method in theCollectionobject. This fix refactors theupdate_documentmethod inChromato correctly interact with theCollectionobject.Changes
update_documentmethod in theChromaclass to correctly call methods on theCollectionobject.test_chroma_update_documentintests/integration_tests/vectorstores/test_chroma.pyto reflect the updated method call.update_documentfunction in the Jupyter notebook tutorial for Chroma.Test Plan
All existing tests pass after this change. In addition, the
test_chroma_update_documenttest case now correctly checks the functionality ofupdate_document, ensuring that the function works as expected and updates the content of documents correctly.Reviewers
@dev2049
This fix will ensure that users are able to use the
update_documentfunction as expected, without encountering the previousAttributeError. This will enhance the usability and reliability of the Chroma class for all users.Thank you for considering this pull request. I look forward to your feedback and suggestions.