Text splitter for Markdown files by header #5860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwchase17
reviewed
Jun 8, 2023
hwchase17
reviewed
Jun 8, 2023
rlancemartin
force-pushed
the
rlm/markdown_splitter
branch
from
8506e9e
to
f6e1909
Compare
rlancemartin
changed the title
rlancemartin
force-pushed
the
rlm/markdown_splitter
branch
from
f6e1909
to
ed23ae4
Compare
Done. Added to notebook. |
Re-organized code a bit; we no longer do this. |
rlancemartin
force-pushed
the
rlm/markdown_splitter
branch
4 times, most recently
from
450efd1
to
06894b4
Compare
rlancemartin
force-pushed
the
rlm/markdown_splitter
branch
11 times, most recently
from
4840d6b
to
3365aaf
Compare
rlancemartin
force-pushed
the
rlm/markdown_splitter
branch
from
3365aaf
to
f65227d
Compare
Undertone0809
pushed a commit
to Undertone0809/langchain
that referenced
this pull request
Jun 19, 2023
This creates a new kind of text splitter for markdown files. The user can supply a set of headers that they want to split the file on. We define a new text splitter class, `MarkdownHeaderTextSplitter`, that does a few things: (1) For each line, it determines the associated set of user-specified headers (2) It groups lines with common headers into splits See notebook for example usage and test cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a new kind of text splitter for markdown files.
The user can supply a set of headers that they want to split the file on.
We define a new text splitter class,
MarkdownHeaderTextSplitter, that does a few things:(1) For each line, it determines the associated set of user-specified headers
(2) It groups lines with common headers into splits
See notebook for example usage and test cases.