Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: spedd up integration test by using smaller model #6044

Conversation

JensMadsen
Copy link
Contributor

@JensMadsen JensMadsen commented Jun 12, 2023

Adds a new parameter relative_chunk_overlap for the SentenceTransformersTokenTextSplitter constructor. The parameter sets the chunk overlap using a relative factor, e.g. for a model where the token limit is 100, a relative_chunk_overlap=0.5 implies that chunk_overlap=50

Tag maintainers/contributors who might be interested:

@hwchase17, @dev2049

@JensMadsen JensMadsen force-pushed the relativeChunkOverlapForSentenceTransformerTextSplitter branch from 8e5c0e6 to 7d3dc3b Compare June 12, 2023 13:22
@JensMadsen JensMadsen marked this pull request as ready for review June 12, 2023 13:40
Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@hwchase17 hwchase17 merged commit 2c91f0d into langchain-ai:master Jun 12, 2023
Undertone0809 pushed a commit to Undertone0809/langchain that referenced this pull request Jun 19, 2023
…#6044)

Adds a new parameter `relative_chunk_overlap` for the
`SentenceTransformersTokenTextSplitter` constructor. The parameter sets
the chunk overlap using a relative factor, e.g. for a model where the
token limit is 100, a `relative_chunk_overlap=0.5` implies that
`chunk_overlap=50`

Tag maintainers/contributors who might be interested:

 @hwchase17, @dev2049
This was referenced Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants