add functions agent #6113
Merged
add functions agent #6113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfcampos
approved these changes
Jun 13, 2023
3 tasks
timbogit
reviewed
Jun 18, 2023
Comment on lines
-45
to
+53
| class AgentAction(NamedTuple): | ||
| @dataclass | ||
| class AgentAction: |
There was a problem hiding this comment.
Removal of the NamedTuple base class relationship (and making it a @dataclass instead) breaks the "Accessing Intermediate Steps" How-To, as AgentAction objects now are no longer JSON serializable.
@hwchase17 Any thoughts on how to best address this?
There was a problem hiding this comment.
The same situation I encountered，why you change NamedTuple to dataclass ? AgentAction can extend BaseModel?
Undertone0809
pushed a commit
to Undertone0809/langchain
that referenced
this pull request
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.