Fixed PermissionError on windows #6170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed PermissionError that occurred when downloading PDF files via http in BasePDFLoader on windows.
When downloading PDF files via http in BasePDFLoader, NamedTemporaryFile is used.
This function cannot open the file again on Windows.Python Doc
So, we created a temporary directory with TemporaryDirectory and placed the downloaded file there.
temporary directory is deleted in the deconstruct.
Fixes #2698
Who can review?
Tag maintainers/contributors who might be interested: