feat: add similarity_search_by_vector_with_relevance_scores to Pineco… #6286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hwchase17
reviewed
Jun 19, 2023
…milarity_search_with_relevance_scores
|
@JCourt1 is attempting to deploy a commit to the LangChain Team on Vercel. A member of the Team first needs to authorize it. |
Yes, sounds good, just pushed that! |
hwchase17
pushed a commit
that referenced
this pull request
Jun 20, 2023
Just so it is consistent with other `VectorStore` classes. This is a follow-up of #6056 which also discussed the potential of adding `similarity_search_by_vector_returning_embeddings` that we will continue the discussion here. potentially related: #6286 #### Who can review? Tag maintainers/contributors who might be interested: @rlancemartin <!-- For a quicker response, figure out the right person to tag with @ @hwchase17 - project lead Tracing / Callbacks - @agola11 Async - @agola11 DataLoaders - @eyurtsev Models - @hwchase17 - @agola11 Agents / Tools / Toolkits - @hwchase17 VectorStores / Retrievers / Memory - @dev2049 -->
dosubot
bot
added
Ɑ: vector store
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #6056, the underlying langchain VectorStore class doesn't have a method called
similarity_search_by_vector_with_relevance_scoresto allow getting a handle on the relevance scores when querying by vector, similarly to how it is done withsimilarity_searchandsimilarity_search_with_relevance_scores.Since adding such an abstract method to the base
VectorStoreclass would require implementing it for allVectorStores, I haven't done that here. As a baby step towards the larger task, I have just addedsimilarity_search_by_vector_with_relevance_scoresto thePineconevector store.Who can review?
Tag maintainers/contributors who might be interested:
VectorStores / Retrievers / Memory