Harrison/typesense fix #6391
Merged
Harrison/typesense fix #6391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6159) Changes done. 1. Example code in Typesense Class provided input embedding as `embedding=embedding.embed_query` which throws an error as `AttributeError: 'function' object has no attribute 'embed_query'`. 2. modified k values in vector similarity as Typesense by default returns 10 results. So providing k =4 by default would make users think about why the results are returned 10 instead of 4. #### Who can review? @jasonbosco @hwchase17 @dev2049 Co-authored-by: gaurav <gaurav.chauhan1@rksv.in>
hwchase17
added
the
lgtm
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.