Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make bs4 a local import in recursive_url_loader.py #6693

Merged
merged 1 commit into from
Jun 24, 2023
Merged

Make bs4 a local import in recursive_url_loader.py #6693

merged 1 commit into from
Jun 24, 2023

Conversation

rlancemartin
Copy link
Collaborator

Resolve #6679

@vercel
Copy link

vercel bot commented Jun 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Jun 24, 2023 8:49pm

@rlancemartin rlancemartin changed the title Make bs4 a local import Make bs4 a local import in recursive_url_loader.py Jun 24, 2023
@rlancemartin rlancemartin mentioned this pull request Jun 24, 2023
Closed
14 tasks
@rlancemartin rlancemartin merged commit dd36adc into langchain-ai:master Jun 24, 2023
This was referenced Jun 25, 2023
Closed
Merged
@rlancemartin rlancemartin mentioned this pull request Jun 26, 2023
Merged
@dosubot dosubot bot mentioned this pull request Jan 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dev2049 dev2049 dev2049 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

crash because of missing bs4 dependency in version 2.12
2 participants
@rlancemartin @dev2049