Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second Attempt - Add concurrent insertion of vector rows in the Cassandra Vector Store #7017

Merged

Conversation

hemidactylus
Copy link
Contributor

Retrying with the same improvements as in #6772, this time trying not to mess up with branches.

@rlancemartin doing a fresh new PR from a branch with a new name. This should do. Thank you for your help!

@vercel
Copy link

vercel bot commented Jul 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Jul 1, 2023 6:01pm

@dosubot dosubot bot added 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder 🤖:improvement Medium size change to existing code to handle new use-cases labels Jul 1, 2023
@rlancemartin rlancemartin self-assigned this Jul 1, 2023
@hemidactylus
Copy link
Contributor Author

(Incidentally, my make lint did not catch the line too long error, which I see only after submitting the PR as a reason for failure of the "Python 3.8 build" task (IIRC).
What would be the way to run such extended testing locally (I'm asking with he intent of simplifying the work on your side) ?

@rlancemartin
Copy link
Collaborator

@dev2049

(Incidentally, my make lint did not catch the line too long error, which I see only after submitting the PR as a reason for failure of the "Python 3.8 build" task (IIRC). What would be the way to run such extended testing locally (I'm asking with he intent of simplifying the work on your side) ?

Ya, usually I just look at the specific command that was run in the test and then run it locally (e.g., poetry run black .) for ongoing testing.

@rlancemartin rlancemartin merged commit 8d2281a into langchain-ai:master Jul 1, 2023
13 checks passed
vowelparrot pushed a commit that referenced this pull request Jul 4, 2023
…ndra Vector Store (#7017)

Retrying with the same improvements as in #6772, this time trying not to
mess up with branches.

@rlancemartin doing a fresh new PR from a branch with a new name. This
should do. Thank you for your help!

---------

Co-authored-by: Jonathan Ellis <jbellis@datastax.com>
Co-authored-by: rlm <pexpresss31@gmail.com>
@hemidactylus hemidactylus deleted the SL-cassandra-vectorstore-3 branch August 31, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder 🤖:improvement Medium size change to existing code to handle new use-cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants