Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BaseChatModel.astream to respect generation_info #9430

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Update BaseChatModel.astream to respect generation_info #9430

merged 3 commits into from
Aug 22, 2023

Conversation

caffeinism
Copy link
Contributor

Currently, generation_info is not respected by only reflecting messages in chunks. Change it to add generations so that generation chunks are merged properly.

@vercel
Copy link

vercel bot commented Aug 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2023 7:23am

@dosubot dosubot bot added Ɑ: models Related to LLMs or chat model modules 🤖:improvement Medium size change to existing code to handle new use-cases labels Aug 18, 2023
hwchase17
hwchase17 reviewed Aug 20, 2023
View reviewed changes
Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this seems reasonable to me - do we want to do the same for normal stream?

i will switch that and then add a test

@caffeinism
Copy link
Contributor Author

I missed that part. lgtm.

@baskaryan baskaryan merged commit ca8232a into langchain-ai:master Aug 22, 2023
22 checks passed
rlancemartin pushed a commit that referenced this pull request Aug 22, 2023
@caffeinism @hwchase17 @rlancemartin
Update BaseChatModel.astream to respect generation_info (#9430)
ee89eb8 
Currently, generation_info is not respected by only reflecting messages
in chunks. Change it to add generations so that generation chunks are
merged properly.

---------

Co-authored-by: Harrison Chase <hw.chase.17@gmail.com>
@caffeinism caffeinism deleted the caffeinism-patch-1 branch August 23, 2023 06:53
@tristinbaileel tristinbaileel mentioned this pull request Nov 1, 2023
Open
@dr-juetz dr-juetz mentioned this pull request Nov 1, 2023
Open
@dewankpant dewankpant mentioned this pull request Nov 2, 2023
Open
@dr-juetz dr-juetz mentioned this pull request Nov 15, 2023
Open
@tristinbaileel tristinbaileel mentioned this pull request Nov 15, 2023
Open
@dewankpant dewankpant mentioned this pull request Nov 15, 2023
Open
@bozza-man bozza-man mentioned this pull request Nov 16, 2023
Open
@dewankpant dewankpant mentioned this pull request Nov 25, 2023
Open
@tristinbaileel tristinbaileel mentioned this pull request Nov 25, 2023
Open
@dr-juetz dr-juetz mentioned this pull request Nov 27, 2023
Open
@mjuetz mjuetz mentioned this pull request Jan 5, 2024
Open
@abdulrahman305 abdulrahman305 mentioned this pull request Apr 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchase17 hwchase17 hwchase17 left review comments

Assignees
No one assigned
Labels
🤖:improvement Medium size change to existing code to handle new use-cases Ɑ: models Related to LLMs or chat model modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caffeinism @hwchase17 @baskaryan