core[patch]: fix: Document should handle empty pageContent (fixes #5884…

…) (#5885) * fix: Document should handle empty pageContent (fixes #5884) * Format --------- Co-authored-by: jacoblee93 <jacoblee93@gmail.com>
langchain-ai · Jun 25, 2024 · 5b73067 · 5b73067
1 parent 43829d6
commit 5b73067
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/langchain-core/src/documents/document.ts b/langchain-core/src/documents/document.ts
@@ -29,9 +29,8 @@ export class Document<
   metadata: Metadata;
 
   constructor(fields: DocumentInput<Metadata>) {
-    this.pageContent = fields.pageContent
-      ? fields.pageContent.toString()
-      : this.pageContent;
+    this.pageContent =
+      fields.pageContent !== undefined ? fields.pageContent.toString() : "";
     this.metadata = fields.metadata ?? ({} as Metadata);
   }
 }
diff --git a/langchain-core/src/tests/document.test.ts b/langchain-core/src/tests/document.test.ts
@@ -0,0 +1,7 @@
+import { test, expect } from "@jest/globals";
+import { Document } from "../documents/document.js";
+
+test("Document should handle empty pageContent", () => {
+  const doc = new Document({ pageContent: "" });
+  expect(doc.pageContent).toEqual("");
+});