Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-common [feature]: Support JSON Mode for Gemini #5071

Closed
1 task done
afirstenberg opened this issue Apr 11, 2024 · 3 comments · Fixed by #5190
Closed
1 task done

google-common [feature]: Support JSON Mode for Gemini #5071

afirstenberg opened this issue Apr 11, 2024 · 3 comments · Fixed by #5190
Labels
auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features

Comments

@afirstenberg
Copy link
Contributor

Privileged issue

  • I am a LangChain maintainer, or was asked directly by a LangChain maintainer to create an issue here.

Issue Content

See documentation for responseMimeType at https://cloud.google.com/vertex-ai/generative-ai/docs/model-reference/gemini#request_body

See langchain-ai/langchain-google#144
@afirstenberg afirstenberg mentioned this issue Apr 11, 2024
Closed
@dosubot dosubot bot added the auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features label Apr 11, 2024
@JackFener
Copy link
Contributor

JackFener commented Apr 22, 2024 •
edited
Loading

already managed to add it. would you like to assign it to me?
I'll add some test and then open a pull request.

I would be happy to work also on the other google common issues

JackFener pushed a commit to JackFener/langchainjs that referenced this issue Apr 23, 2024
@GiacomoCherry
google-common [feature]: Support JSON Mode for Gemini langchain-ai#5071
3c63206
@JackFener JackFener mentioned this issue Apr 23, 2024
Merged
bracesproul added a commit that referenced this issue May 1, 2024
@JackFener @GiacomoCherry @bracesproul
google-common [feature]: Support JSON Mode for Gemini #5071 (#5190)
89ba4a0 
* google-common [feature]: Support JSON Mode for Gemini #5071

* added mock json file for tests

* defined GoogleAIResponseMimeType type

* responseMimetype default specified in the GoogleBaseLLM class that implements it

* test to make sure the request contains the responseMimeType setting in the generation config

* Format llms.test.ts

* Format llms.ts

* Format types.ts

* Nit types.ts jsdoc

* Format types.ts

---------

Co-authored-by: GiacomoCherry <giacomo.fava@cherrynpl.com>
Co-authored-by: Brace Sproul <braceasproul@gmail.com>
@rossanodr
Copy link

How can I use it ChatGoogleGenerativeAI?

@aechegoyan17 aechegoyan17 mentioned this issue Jun 6, 2024
Open
@riderx riderx mentioned this issue Jun 9, 2024
Closed
This was referenced Jun 11, 2024
Merged
Merged
@Avish24x Avish24x mentioned this issue Jun 20, 2024
Open
@hongkongkiwi
Copy link
Contributor

The docs show this as missing from this provider still?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

google-common [feature]: Support JSON Mode for Gemini #5071 JackFener/langchainjs
4 participants
@hongkongkiwi @afirstenberg @JackFener @rossanodr